Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow release please to sign commits #1247

Open
weboko opened this issue Mar 16, 2023 · 1 comment
Open

chore: allow release please to sign commits #1247

weboko opened this issue Mar 16, 2023 · 1 comment
Assignees
@weboko
Labels
good first issue Good for newcomers infra Infra, devops, CI and related tasks

Comments

@weboko
Copy link
Collaborator

weboko commented Mar 16, 2023

This is a support request

Problem

Currently we had to remove hard rule for all commits to be signed to unblock the release #1237

Proposed Solutions

We need to add GPG token to allow release-please to sign it's commits
https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#gpg-commit-signature-verification
@fryorcraken fryorcraken added this to Waku Mar 16, 2023
@weboko weboko added the good first issue Good for newcomers label Mar 16, 2023
@weboko weboko moved this to Triage in Waku Mar 16, 2023
@weboko weboko added the infra Infra, devops, CI and related tasks label Mar 16, 2023
@weboko weboko mentioned this issue Mar 16, 2023
Merged
@fryorcraken fryorcraken moved this from Triage to Priority in Waku Mar 23, 2023
@weboko weboko moved this from Priority to In Progress in Waku Mar 23, 2023
@weboko weboko self-assigned this Mar 23, 2023
@weboko
Copy link
Collaborator Author

weboko commented Mar 29, 2023

Putting on hold for the time being since release-please underlying library does not support it and there is no workaround for now.

googleapis/code-suggester#337

@weboko weboko moved this from In Progress to Icebox in Waku Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weboko weboko

Labels
good first issue Good for newcomers infra Infra, devops, CI and related tasks
Projects
Waku
Status: Icebox
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weboko