Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify API of bootstrapping, connection to MetaMask #92

Merged
merged 7 commits into from
Jan 24, 2024
Merged

feat: simplify API of bootstrapping, connection to MetaMask #92

merged 7 commits into from
Jan 24, 2024

Conversation

weboko
Copy link
Contributor

@weboko weboko commented Jan 23, 2024

This PR is firs steps to improve API of js-rln.
Inside following simplifications are made:

Metamask:

  • abstraction to get provider with triggering dialog from Metamask
  • ability to pass it from outside

RLN Instance:

  • dedicated step for starting: bootstraps RLN Contract
  • expose RLN contract from instance

adklempner
adklempner reviewed Jan 24, 2024
View reviewed changes
src/metamask.ts Outdated Show resolved Hide resolved
adklempner
adklempner approved these changes Jan 24, 2024
View reviewed changes
src/rln.ts Outdated Show resolved Hide resolved
@weboko weboko merged commit bafbe01 into master Jan 24, 2024
4 of 5 checks passed
@weboko weboko deleted the weboko/new-api branch January 24, 2024 20:23
@weboko weboko mentioned this pull request Jan 29, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adklempner adklempner adklempner approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weboko @adklempner