Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: proof is not verified #79

Closed
weboko opened this issue Oct 30, 2023 · 4 comments · Fixed by #86
Closed

bug: proof is not verified #79

weboko opened this issue Oct 30, 2023 · 4 comments · Fixed by #86
Assignees
@weboko
Labels
bug Something isn't working track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@weboko
Copy link
Contributor

weboko commented Oct 30, 2023

Right now proof is generated and sent with message.

The problem happens when proof is tried to be verified in rln-js example here

.verify operation uses verifyWithRoots

At the same time verifyRLNProof is able to verify proof.
@weboko weboko added bug Something isn't working track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications labels Oct 30, 2023
@weboko weboko self-assigned this Oct 30, 2023
@weboko weboko added this to Waku Oct 30, 2023
@weboko weboko moved this to In Progress in Waku Oct 30, 2023
@weboko
Copy link
Contributor Author

weboko commented Oct 30, 2023

Ping @rymnc maybe you can get a pointer for investigation here

@rymnc
Copy link

rymnc commented Oct 31, 2023

This could happen when the roots are invalid, can you log out the root when the proof is generated, and the roots that are being passed into verifyWithRoots?

@weboko
Copy link
Contributor Author

weboko commented Nov 5, 2023

Weekly update:

  • achieved: as per suggestion investigated if the roots are correct, seems found a fix;

@weboko weboko mentioned this issue Nov 8, 2023
Merged
@weboko weboko moved this from In Progress to Blocked in Waku Nov 22, 2023
@weboko
Copy link
Contributor Author

weboko commented Nov 22, 2023

moving to blocked until discussion with @rymnc this Friday

seems that when root is computed in zerokit it is not present in roots from contract and thus validation with proofs fails

@weboko weboko mentioned this issue Dec 1, 2023
Merged
@weboko weboko closed this as completed in #86 Dec 1, 2023
@github-project-automation github-project-automation bot moved this from Blocked to Done in Waku Dec 1, 2023
@weboko weboko mentioned this issue Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weboko weboko

Labels
bug Something isn't working track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: idCommitmnet little endianess waku-org/js-rln
2 participants
@rymnc @weboko