Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean nullifier table #68

Open
fryorcraken opened this issue Sep 22, 2023 · 2 comments
Open

clean nullifier table #68

fryorcraken opened this issue Sep 22, 2023 · 2 comments
Assignees
@weboko
Labels
E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@fryorcraken
Copy link
Contributor

No description provided.

@fryorcraken fryorcraken added this to Waku Sep 22, 2023
@fryorcraken
Copy link
Contributor Author

@richard-ramos can you please provide details?

@fryorcraken fryorcraken added track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details labels Sep 22, 2023
@weboko weboko self-assigned this Sep 22, 2023
@weboko weboko moved this to Triage in Waku Sep 22, 2023
@weboko weboko moved this from Triage to To Do in Waku Oct 31, 2023
@richard-ramos
Copy link
Member

I think we don't have a nullifier log in js-rln although it would be a good addition, since it can be used to detect if a message is duplicated or not:

Here's how it is used within go-waku's validator used by waku relay:
https://github.com/waku-org/go-waku/blob/b7105f9b9f64fa12fed6ca2fb2d52ab80584a560/waku/v2/protocol/rln/waku_rln_relay.go#L162-L180

And the logic for the cleanup:
https://github.com/waku-org/go-waku/blob/master/waku/v2/protocol/rln/nullifier_log.go#L91-L120

@chair28980 chair28980 moved this from To Do to Icebox in Waku Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weboko weboko

Labels
E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
Waku
Status: Icebox
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richard-ramos @fryorcraken @weboko