-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeepL target_lang for EN-GB and EN-US #738
Comments
@unreadableusername I think the note on |
You'll get me started on a rant about EN being taken to mean EN-US when US English is a dialect of English only used in parts of North America 😂. European (and more) sites that use EN mean international English which definitely is not US English. It's a bit like using FR and getting Quebecois instead. I've always thought there should be a configurable default locale when using language codes. Having to specify something like EN-GB in the url to get non-American English makes no sense and makes the reader it's something UK specific. |
Added tests and merged in a3efa8f |
The DeepL API documentation specifies to use EN-GB or EN-US to archieve the desired translation, however following code in the deepl.py will chop off the -GB or -US and the deprecated unspecified route will be used.
I suggest to add en-gb and en-us to the array inside the if statement above to respect users desired locale setting.
Please tell me if this is shortsightet or more complicated then this 😅
The text was updated successfully, but these errors were encountered: