Fix link style in Safari #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shorthand does not quite work in Safari. Therefore, we need to define the different components individually.
| @@ -1,6 +1,9 @@ | |||
| a { | |||
| color: $link-color; | |||
| text-decoration: 2px solid underline; | |||
There was a problem hiding this comment.
We should drop this line now
There was a problem hiding this comment.
I wonder if that would have unintended side effects in other browsers
There was a problem hiding this comment.
I have checked on mdn web docs. All browsers support long hand versions. Only Firefox for Android doesn't support text-decoration-thickness neither in short nor in long hand way. So I think removing it will be safe.
Thank you for the mention 😄 |
Stormheg
added a commit
to Stormheg/sphinx_wagtail_theme
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shorthand does not quite work in Safari. Therefore, we need to define the different components individually.
Thanks to @PaarthAgarwal for the pointer!
Before
After
Close #155