Make navigation sticky #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: How does this behave on small screens (when the menu is collapsed normally and has to be expanded)? |
|
@tbrlpld To answer your question, I've checked using the developer tools in the browser, and it behaves fine. On smaller devices where the mobile menu appears, the navigation starts out at the top, and you can scroll down the page past the navigation and through the page content. To summarize, the behavior of the navigation on smaller devices (at both orientations) is exactly the same with or without the |
|
@tbrlpld Anything more needed from me in order to have this PR approved? |
|
@DanielSwain Looks good to me (just tried it locally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.