-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About the "respond" review mode #2
Comments
Hi again, sorry for the various edits of this comment. I believe that what could be missing in order to ever get a
Thanks to Maylon for the final idea. Also, after some thought, I think it could be useful to have the default modes for submitters, reviewers and users to be defined in the settings file, maybe something like:
Then in admin.py we could have the following:
This would allow the developer to decide based on the specific use case what to do while having the fallback to the default behaviour if the variables are not defined.
I will create a PR shortly, hopefully you'll like the idea. |
Hi!
So, I have been trying to add this, everything seems to work out of the box except for one thing.
This is what I would like to see in my review page:
And this in my
Audit Trail
:In my case, I can never see the nice
respond
window, nor the comment or status in theAudit Trail
(see images above) unless I hard code it like this:'allow_responses': True,
in wagtailreview_tags.pyI have noticed there are three values for
wagtailreview_mode
:view
,comment
andrespond
I believe the
respond
mode is missing in theview_review_page
view in admin.py or maybe I am not fully understanding or I am just missing something?I am the designated reviewer (in case you could think I jsut don't have permissions)
It is impossible for me, with the code as is, to ever entrer a review in
respond
mode, so my questions would be:Thanks for this piece of code and I hope you can respond soon!
Cheers!
The text was updated successfully, but these errors were encountered: