fix: BaseError@walk
to return null
when predicate fn not matches
#874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, the current implementation of
BaseError@walk(fn?)
has a bug whenfn
is provided and no error matches itCurrent behavior: the deepest error will be returned
Expected behavior:
null
should be returnedPR-Codex overview
Focus of the PR:
Fixing the
BaseError.walk
function to returnnull
if the predicate callback is not satisfied.Detailed summary:
BaseError.walk
to returnnull
if the predicate callback is not satisfied.walk
insrc/errors/base.ts
.walk
insrc/errors/base.test.ts
.