Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rpc error code #783

Merged
merged 3 commits into from
Jun 25, 2023
Merged

feat: rpc error code #783

merged 3 commits into from
Jun 25, 2023

Conversation

izayl
Copy link
Contributor

@izayl izayl commented Jun 25, 2023

PR-Codex overview

This PR adds a static code property to RPC Error classes and updates the buildRequest function to use a switch statement for error handling.

Detailed summary

  • Adds a static code property to RPC Error classes
  • Updates buildRequest function to use a switch statement for error handling.

The following files were skipped due to too many changes: src/utils/buildRequest.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2023

🦋 Changeset detected

Latest commit: aa218f4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 25, 2023

@izayl is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #783 (ab3bf94) into main (3d55f1f) will decrease coverage by 5.07%.
The diff coverage is 100.00%.

❗ Current head ab3bf94 differs from pull request most recent head aa218f4. Consider uploading reports for the commit aa218f4 to get more accurate results

@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   99.92%   94.86%   -5.07%     
==========================================
  Files         259      250       -9     
  Lines       24140    23781     -359     
  Branches     2006     1772     -234     
==========================================
- Hits        24123    22560    -1563     
- Misses         17     1209    +1192     
- Partials        0       12      +12     
Impacted Files Coverage Δ
src/errors/rpc.ts 100.00% <100.00%> (ø)
src/utils/buildRequest.ts 100.00% <100.00%> (ø)

... and 123 files with indirect coverage changes

@jxom jxom merged commit 91e85c7 into wevm:main Jun 25, 2023
@github-actions github-actions bot mentioned this pull request Jun 25, 2023
@izayl izayl deleted the feature/rpc-error-code branch June 26, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants