feat: make payable value required #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 117d097 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 251 kB ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #397 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 267 267
Lines 22599 22599
Branches 1915 1918 +3
=======================================
Hits 22575 22575
Misses 21 21
Partials 3 3 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jxom
approved these changes
Apr 20, 2023
Merged
jxom
pushed a commit
that referenced
this pull request
Apr 23, 2023
* feat: make payable value required * fix: types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on adding a required
valueparameter for payable functions.Detailed summary
valueparameter for payable function calls insimulateContract.test.tsandestimateContractGas.test.tscontract.tsandcontract.test-d.tsto makevaluea required parameter for payable functionsclever-drinks-rule.mdto reflect the changes made in this PR