Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decodeEventLog topics mismatch #198

Merged
merged 3 commits into from
Mar 12, 2023
Merged

Conversation

wighawag
Copy link
Contributor

@wighawag wighawag commented Mar 12, 2023

Fixes #197
Fixes #180

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2023

🦋 Changeset detected

Latest commit: 07071cd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 12, 2023

@wighawag is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@jxom
Copy link
Member

jxom commented Mar 12, 2023

Thanks for the PR! Just added some refactors I've been meaning to do which will also close #180 as well.

for (let i = 0; i < inputs.length; i++) {
const param = inputs[i]
const topic = argTopics[i]
if (topic === null) args[param.name || i] = null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed as a topic on a log cannot be null.

const topic = argTopics[i]
if (topic === null) args[param.name || i] = null
if (!topic) continue
if (Array.isArray(topic)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed as a topic on a log cannot be an array.

@jxom jxom changed the title Decode logs failure fix: decodeEventLog topics mismatch Mar 12, 2023
@jxom jxom merged commit e805e7e into wevm:main Mar 12, 2023
@github-actions github-actions bot mentioned this pull request Mar 12, 2023
@wighawag
Copy link
Contributor Author

Thanks for the PR! Just added some refactors I've been meaning to do which will also close #180 as well.

ha yes was wondering about those topic values myself :)
thanks for getting that PR in that quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants