Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decoding event logs if constructor in abi #159

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

jxom
Copy link
Member

@jxom jxom commented Mar 8, 2023

Fixes #157

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

🦋 Changeset detected

Latest commit: 484744d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
viem ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 10:20AM (UTC)
viem-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 10:20AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Size Change: +20 B (0%)

Total Size: 43.5 kB

Filename Size Change
dist/abi.js 259 B +2 B (+1%)
dist/chunk-6CICSWSU.js 0 B -32.3 kB (removed) 🏆
dist/chunk-PGDJ2CCF.js 0 B -1.7 kB (removed) 🏆
dist/contract.js 440 B +3 B (+1%)
dist/index.js 4.52 kB +2 B (0%)
dist/public.js 458 B +1 B (0%)
dist/test.js 507 B +2 B (0%)
dist/utils/index.js 1.01 kB +3 B (0%)
dist/wallet.js 284 B +2 B (+1%)
dist/chunk-CBZ4DHZM.js 1.7 kB +1.7 kB (new file) 🆕
dist/chunk-SFB4ZJ54.js 32.3 kB +32.3 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
dist/chains.js 1.59 kB
dist/ens.js 343 B
dist/window.js 67 B

compressed-size-action

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #159 (484744d) into main (1c19e42) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         215      215           
  Lines       12578    12580    +2     
  Branches     1355     1356    +1     
=======================================
+ Hits        12560    12562    +2     
  Misses         17       17           
  Partials        1        1           
Impacted Files Coverage Δ
src/utils/abi/decodeEventLog.ts 99.08% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jxom jxom merged commit 574ae22 into main Mar 8, 2023
@jxom jxom deleted the jxom/fix-decode-event-log-constructor branch March 8, 2023 10:36
@github-actions github-actions bot mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: decodeEventLog throws if the ABI contains an item with type: "constructor"
1 participant