-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when deploying functions without .runtimeconfig.json #86
Comments
@w9jds any ideas? |
Sounds like you are using firebase configs in your functions and haven't set them properly. This isn't related to the action. |
The are definitely setup properly as I have no problems deploying from my local machine. I guess this is more of a usage question than a bug or error. How am I meant to deploy functions with this action when I cannot commit the |
runtimeconfig.json is just for the emulator I think. When you run |
@sam-jg , were you able to solve the issue? |
This is probably late but if you still need an answer to this. You can pass your argument as It's not advisable to push your |
@calebdeji How would I set the functions config and deploy at the same time? args: functions:config:set foo="bar" deploy --only functions This is not working for me. |
You may need to chain your requests, you can't set the args and deploy at the same time, you'll get a key=value error from the Firebase CLI |
@db-dblank Use the following to simultaneously set your environment variables and deploy your function args: functions:config:set ${{ secrets.FIREBASE_FUNCTIONS_ENV_VARIABLES }} ; firebase deploy --only functions |
Can we have an extra step to fetch the config into a JSON then start to deploy? similar to
It doesn't make sense to save as secrets because the config variables could be updated/unset from local and doing |
This is the action log, and 'rumtimeconfig' that shouldn't be required for deploy. It is strange.
The |
We fixed it by adding We got confused about the |
I get the following error when deploying from github using this action.
I assume the error is because there is no
.runtimeconfig.json
file committed to the repo and therefore not accessible to the action. I can't commit the file, because it contains secrets.Is there any recommended work around for this?
The text was updated successfully, but these errors were encountered: