Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dx Station sends full exchange after user sends partial callsign #382

Open
w7sst opened this issue Dec 1, 2024 · 3 comments
Open

Dx Station sends full exchange after user sends partial callsign #382

w7sst opened this issue Dec 1, 2024 · 3 comments
Assignees
Labels
bug Something isn't working confirmed This bug has been confirmed fixed - ready for validation bug is fixed; ready for validation

Comments

@w7sst
Copy link
Owner

w7sst commented Dec 1, 2024

Description

Tim, N0UI, reported this issue on groups.io...

Mike:

I noticed a behavior in the recent version of MorseRunnerCE I wanted to mention. I have used Alex's Ver. 1.68 for a long time. I was glad to use your Ver. 1.84 to prepare for the IARU this summer. Adding contests has been appreciated. Thanks for taking the time and making the effort to improve on this project.

When I upgraded to 1.85, and then 1.85.1 from 1.84, I noticed a behavior change in the IARU contest. I send a partial call in response to a pileup, and A LOT of the stations will not just send their call, but their full exchange. Now, I know you want this behavior occasionally, but the percentage seems to be around 90%. I haven't tested this beyond the IARU contest setup yet.

I usually run quick 10 minute sessions, and it always seems to start up within the first couple of minutes, then keep occurring for the > rest of the session.

Tim Raymer
73 de N0UI

My response...

Hi Tim,

Thank you for reporting this issue. We did make some changes in how responses are generated for v1.85, so I appreciate the feedback.

Question... Are you sending your partial callsign using F5 key or the Enter key? The program's logic will treat each key differently. F5 only sends the partial call, whereas the Enter key will send your call and your exchange. Based on what you have said, I think you are using the F5 key only.

Thank you for your feedback.

73, Mike W7SST

Sean, N3RTW, added...

I haven't tracked the versions as closely, but in the latest MorseRunner CE it does this same thing on the CWTs. I use the F5 key to > send a partial call and I'll usually get the full call and exchange in response.

Sean N3RTW

And finally Tim's response to my question...

Question... Are you sending your partial callsign using F5 key or the Enter key? The program's logic will treat each key differently. F5 only sends the partial call, whereas the Enter key will send your call and your exchange. Based on what you have said, I think you are using the F5 key only.

Mike,

Indeed, this is in an F5 Partial call scenario that this happens.

Thanks for taking note of the issue.

Tim Raymer
73 de N0UI

Version

  • 1.85 and 1.85.1
@w7sst w7sst added bug Something isn't working confirmed This bug has been confirmed labels Dec 1, 2024
@w7sst w7sst self-assigned this Dec 1, 2024
@w7sst
Copy link
Owner Author

w7sst commented Dec 1, 2024

My response back to groups.io...

Hi Tim, Thank you for clarifying. I found the code that is causing the problem. It is happening about 50% of the time - sometimes with the caller is sending the corrected call being sent twice and sometimes only once along with the full exchange.

I also notice that the calling station should only send their exchange when the user sends his exchange first. I realize the bug is the calling station is sending their exchange before the user has sent their exchange. In this reported case, the F5 key is sending the partial call without an exchange. Thus, the caller should only send their corrected call without an exchange.

This behavior change (in 1.85) was motivated by the following article: http://www.k1usn.com/Do%27s%20and%20Don%27ts%20and%20More.pdf

To quote this article (Italics added):

Am I My Brother’s Keeper?

"I know of only one contest where you may be penalized if someone busts your call. In all others, the operator who logs the wrong call gets busted. As an S&Per, you could move up and down the band and work a bunch of runners, and if they screw up your call, you figure that’s their problem, not yours. But, trust me, when people start looking at results and they see that a lot of people busted K6RB’s call, it raises questions. You can’t prevent people from busting your call completely but you can help avoid it, somewhat, by paying attention to what they send. If you are K3PP and you hear a runner come back to K4PP,cdon’t just send “tu 5nn pa.” Send “K3PP (and maybe PP right after) then 5nn pa. You’ve done your job by helping the runner avoid a busted call.

Some people will hold off sending an exchange if a runner sends the wrong call. For example, if I sent K4PP 5nn ca to K3PP, he may send K3PP K3PP and pause without sending an exchange. I would then send K3PP 5nn ca. Then, he would send tu 5nn pa. However, doing this delays both the runner and pouncer, and only the runner is at risk of losing points. So, why not be a good citizen and send K3PP 5nn pa rather than holding off the exchange. If the runner gets it, and fixes it, then great. If not, you’ve done your job without delaying either of you."

I will study this further and either find a fix or reduce the percentage. Perhaps 50% is too much.

73 Mike W7SST

@w7sst
Copy link
Owner Author

w7sst commented Dec 1, 2024

This issue occurred while fixing #315. This original fix did not distinguish between the user sending either

  1. partial callsign with their exchange, or
  2. partial callsign without their exchange.

In both cases, the DxStation was sending their corrected callsign along with their full exchange. This was occurring for both cases above. The DxStation should send their callsign and exchange when the user sends the partial callsign along with their exchange. When the user sends only a partial callsign, the DxStation should respond with only their callsign.

@w7sst
Copy link
Owner Author

w7sst commented Dec 12, 2024

This issue was fixed with merge #384.

  • restores pre-1.85 behavior where DxStation sends only corrected callsign after user sends a partial callsign using F5 Key.
  • v1.85/v1.85.1 was sending both corrected callsign and exchange. Only the corrected callsign should be sent. This is now fixed.
  • The user can use the F5 Key to send a partial callsign.
  • This fix restores original behavior where the DxStation will respond with callsign only after receiving an incorrect or partial callsign.
  • If the user uses the Enter Key and sends both callsign and exchange, then the Dx Station will respond with their callsign and exchange. This will occur most of the time (~80%); otherwise the Dx Station will respond with only their corrected callsign.

@w7sst w7sst added the fixed - ready for validation bug is fixed; ready for validation label Dec 12, 2024
@w7sst w7sst added this to the v1.85.2 - bug fix release milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This bug has been confirmed fixed - ready for validation bug is fixed; ready for validation
Projects
None yet
Development

No branches or pull requests

1 participant