Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request.isReloadNavigation and Request.isHistoryNavigation #289

Closed
3 of 5 tasks
yutakahirano opened this issue Jun 4, 2018 · 4 comments
Closed
3 of 5 tasks

Request.isReloadNavigation and Request.isHistoryNavigation #289

yutakahirano opened this issue Jun 4, 2018 · 4 comments
Assignees

Comments

@yutakahirano
Copy link

yutakahirano commented Jun 4, 2018

Hello TAG!

I'm requesting a TAG review of:

Further details (optional):

You should also know that...

[please tell us anything you think is relevant to this review]

We'd prefer the TAG provide feedback as (please select one):

  • open issues in our Github repo for each point of feedback
  • open a single issue in our Github repo for the entire review
  • leave review feedback as a comment in this issue and @-notify [github usernames]

Please preview the issue and check that the links work before submitting

For background, some decent explainers:

https://github.com/w3c/ServiceWorker/blob/master/explainer.md
https://github.com/zkoch/paymentrequest/blob/gh-pages/docs/explainer.md
https://github.com/WICG/IntersectionObserver/blob/gh-pages/explainer.md (although this one includes IDL, which an explainer should not)

@mfalken
Copy link

mfalken commented Jun 4, 2018

Correction: matto should be @mattto

@yutakahirano
Copy link
Author

Done.

@travisleithead travisleithead self-assigned this Jun 19, 2018
@plinss plinss added this to the 2018-06-26-telcon milestone Jun 19, 2018
@travisleithead
Copy link
Contributor

I took a look at this and think it looks great--addresses developer feedback. And provides an easy to read state that avoids rolling your own system based on cache states.

@torgo
Copy link
Member

torgo commented Jun 26, 2018

We had a discussion on the privacy implications and agreed we were largely happy with this. We noted that @diracdeltas might have further comments regarding the privacy implications? In any case we decided to close. Thank you for flying TAG.

@torgo torgo closed this as completed Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants