Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenschange is easy to mistake for screenchange #12

Closed
kenchris opened this issue Jun 10, 2020 · 3 comments
Closed

screenschange is easy to mistake for screenchange #12

kenchris opened this issue Jun 10, 2020 · 3 comments
Labels
wontfix This will not be worked on

Comments

@kenchris
Copy link

I would suggest something like screenavailabilitychange or similar

@michaelwasserman
Copy link
Member

Is screenchange an existing name for something else, or are you mainly concerned about typos between the plural and singular when specifying the proposed screenschange event from the Screen Enumeration proposal?

I appreciate advice naming the event, but 'availability' might not readily convey that this event would be fired on screen additions/removals and screen property changes (eg. colorDepth). It's certainly worthwhile to explore names further, and maybe even consider separate events for additions, removals, and property changes. I'll attempt to describe this issue in more detail with alternative names and examples soon.

@tomayac
Copy link
Contributor

tomayac commented Sep 7, 2020

I made this mistake, too, when I tested the API for the very first time. In the article, I have highlighted that it's the plural form.

@michaelwasserman
Copy link
Member

I recognize that the plurality is subtle, but the event screenschange fires when a screen is added to or removed from the screens array in the same interface.

There is also a currentscreenchange event that fires when the currentScreen attribute changes, and the Screen interface change event fires when the per-screen attributes change.

I think this naming scheme is coherent and sufficient. Please reopen this issue if there's any new feedback to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants