Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web-platform-tests #125

Closed
yutakahirano opened this issue Jul 3, 2020 · 15 comments
Closed

Add web-platform-tests #125

yutakahirano opened this issue Jul 3, 2020 · 15 comments
Assignees

Comments

@yutakahirano
Copy link
Contributor

@Hexcles's and I have introduced the QuicTransport server in https://github.com/web-platform-tests/wpt/. Please see https://github.com/web-platform-tests/wpt/tree/master/tools/quic.

This is not enabled by default as of now. The most important roadblock is to finalize the server API design, and get consensus among the working/community group. We also need write a wpt/RFC describing the system and workflow.

Are y'all happy with the introduced system? Do you have any questions/comments?

@yutakahirano
Copy link
Contributor Author

@annevk @youennf Do you have any opinions? Do you know people who have interest in Mozilla/Apple?

@annevk
Copy link
Member

annevk commented Aug 4, 2020

@ddragana, @agrover, and @jan-ivar can probably give input here.

@yutakahirano
Copy link
Contributor Author

@ddragana, @agrover, @jan-ivar, @youennf do you have any opinions?

@annevk
Copy link
Member

annevk commented Aug 26, 2020

FWIW, I heard things are still in the early stages design-wise, so making progress in the standards group on that is probably more productive at this point.

@yutakahirano
Copy link
Contributor Author

I think now is a good timing to start thinking about this more seriously. While writing tests too early is not a very good use of time, we have a prototype of the API, and making it testable helps us design it in more detail (e.g., #95).

Please see https://github.com/web-platform-tests/wpt/tree/master/tools/quic for the handlers.
https://github.com/web-platform-tests/wpt/blob/master/webtransport/quic/handlers/client-indication.quic.py is an example handler and https://github.com/web-platform-tests/wpt/blob/master/webtransport/quic/client-indication.sub.any.js uses it.

@jan-ivar
Copy link
Member

jan-ivar commented Oct 21, 2020

Notes from WebTransport Wednesday:

  • We're limited today wrt picking between server libraries, AIO Quic python library is available, updated frequently, and supports data grams.
  • Consensus to proceed with a WPT server, will revisit in 6 months/1 year available server options at that time.
  • Run tests for both transports.
  • Most cases should be ambivalent to whether we use http or quic
  • API remains sufficiently generic.
  • Avoid tests specific to one transport or another at the moment

@yutakahirano
Copy link
Contributor Author

@bashi has started a discussion at web-platform-tests/rfcs#85. Feel free to jump in.

@yutakahirano yutakahirano added the Discuss at next meeting Flags an issue to be discussed at the next WG working label Jun 21, 2021
@jan-ivar
Copy link
Member

jan-ivar commented Jul 6, 2021

Meeting:
-Chrome team is leading the task of creating the first deliverable which is an echo server.

@yutakahirano yutakahirano removed the Discuss at next meeting Flags an issue to be discussed at the next WG working label Jul 6, 2021
@wilaw wilaw added the Discuss at next meeting Flags an issue to be discussed at the next WG working label Jul 28, 2021
@jan-ivar
Copy link
Member

@yutakahirano What are next steps on this? Is there any update or anything we need to discuss at next meeting?

@bashi
Copy link
Contributor

bashi commented Jul 28, 2021

We have a PR to add the test server and a test. The PR is under review. I think we need some follow-up PRs to run the test in wpt.fyi. We also need some integrations with Chromium code base to run the server and tests.

@jan-ivar jan-ivar removed the Discuss at next meeting Flags an issue to be discussed at the next WG working label Aug 4, 2021
@yutakahirano
Copy link
Contributor Author

yutakahirano commented Sep 14, 2021

@bashi wrote a document decribing how to enable the WebTransport over HTTP/3 servre on your local environment. Thank you!

@jan-ivar
Copy link
Member

To be updated with links to web-platform-tests from this spreadsheet.

@foolip
Copy link
Member

foolip commented Oct 7, 2021

Can this be considered done now?

@jan-ivar
Copy link
Member

Yes, WPT tests are up and running at https://wpt.fyi/webtransport. 🎉

Individual issues should be opened for any subsequent tests, and we should use the Needs test label for future spec changing PRs.

@dontcallmedom
Copy link
Member

Shouldn't the instructions in https://docs.google.com/document/d/1OBoZTcC9vDoLTgv_5WUznRFrmwXP0Gprj7V9oOzH9cU/edit be included somewhere directly in the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants