Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose rid (and mid) as metadata on outgoing frames #147

Open
fippo opened this issue Sep 2, 2022 · 3 comments
Open

expose rid (and mid) as metadata on outgoing frames #147

fippo opened this issue Sep 2, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@fippo
Copy link
Collaborator

fippo commented Sep 2, 2022

it seems that we're not exposing rid as metadata on the outgoing stream (on incoming rid should be undefined; mid might be marginally useful):
https://w3c.github.io/webrtc-encoded-transform/#scriptTransform
Given the general thinking (that I don't agree with but that is a different story) that mid/rid is cooler than synchronizationSource should we expose it? Does the same apply to mid?

Use case: https://w3c.github.io/webrtc-nv-use-cases/#auction

@henbos
Copy link
Collaborator

henbos commented Nov 29, 2022

Is there a use case for a mid that is different from RTCRtpTransceiver.mid? Wondering if that part could just work automatically and the person dealing with encoded chunk does not have to care, but I could be wrong here

@fippo
Copy link
Collaborator Author

fippo commented Nov 29, 2022

You don't have the transceiver object when doing this in a worker.

@henbos
Copy link
Collaborator

henbos commented Nov 29, 2022

You don't have the transceiver, but you have a writable stream that is wired up to the transceiver, so the lower layers already know what MID to use. So is there any benefit to exposing it here as well? In theory maybe you wanted to overwrite it, but I don't know if that even makes sense

@alvestrand alvestrand added the enhancement New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants