Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of data and features in Chrome.tabs API #412

Open
yankovichv opened this issue Jun 26, 2023 · 6 comments
Open

Lack of data and features in Chrome.tabs API #412

yankovichv opened this issue Jun 26, 2023 · 6 comments
Labels
enhancement Enhancement or change to an existing feature proposal Proposal for a change or new feature

Comments

@yankovichv
Copy link

We are currently working on a tab manager and have encountered a number of limitations in the API.

  1. API Chrome.tabs does not return data about whether there is a record in the tab (https://gang.manganum.app/hLmwdsD3). To do this, you need to use chrome.tabCapture, which is absolutely redundant just to display the capture status.

  2. The ability to mute a tab is different from muting a browser. It seems to me that extensions should have access to the browser's "Mute site" feature.

There are two kinds of mute: the tab mute and the domain mute. Extensions can set the tab mute, but not the domain mute.
In contrast, the zoom API allows to set both the tab zoom and the domain zoom.

Another problem with this is that the "Mute/unmute site" option in the tab's context menu doesn't work once an extension sets the mute state of a tab. This happens because the tab mute takes precedence over the domain mute.
And, what's worse, once you are in this situation, there's no way for an extension to remove the tab mute from that tab. Even if the extension sets mute=false, the domain mute will still not work.

In summary:
— The user can only control the domain mute.
— The extension can only control the tab mute.
— The tab mute takes precedence over the domain mute.
— Once the tab mute has been set, it cannot be removed.

@xeenon xeenon added proposal Proposal for a change or new feature enhancement Enhancement or change to an existing feature and removed needs-triage labels Jul 6, 2023
@patrickkettner
Copy link
Contributor

original chromium-extensions thread

@dotproto
Copy link
Member

dotproto commented Jul 6, 2023

Quick notes from today's meeting. The issue report raises two primary issues in a numbered list. The first item (tab's media capture state) seems relevant to all browsers and we're interested in discussing further. The second item (tab mute vs. "browser" mute) seems to be a Chromium-specific issue that should be addressed.

Regarding a tab's current media capture state, @Rob--W and @xeenon indicated that they'd like to see more details about the nature of the request. What is the desired outcome? Do you have a rough API shape or feature set that you'd like to see?

@yankovichv
Copy link
Author

@dotproto, our goal is to achieve full functionality for our tab manager.

Chrome's tab manager displays the recording status. We are unable to do this with the chrome.tabs permission.

I think the recording: true/false property on the tab object would be the best solution.

@yankovichv
Copy link
Author

@oliverdunk, what do you think about the mute site feature for extensions in Chrome?

@oliverdunk
Copy link
Member

@oliverdunk, what do you think about the mute site feature for extensions in Chrome?

I haven't spent too much time looking at this, but I'm wondering if the chrome.contentSettings API would be a good home for this. It doesn't feel like a high-priority new API but it may be easy enough to add to something existing.

@yankovichv
Copy link
Author

@oliverdunk , wow, sounds good. If only there were events 🤤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or change to an existing feature proposal Proposal for a change or new feature
Projects
None yet
Development

No branches or pull requests

5 participants