Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore duplicated contexts entries in script.addPreloadScript, session.subscribe and session.unsubscribe #617

Open
sadym-chromium opened this issue Dec 11, 2023 · 2 comments · Fixed by #620 · May be fixed by #628
Open

Ignore duplicated contexts entries in script.addPreloadScript, session.subscribe and session.unsubscribe #617

sadym-chromium opened this issue Dec 11, 2023 · 2 comments · Fixed by #620 · May be fixed by #628
Labels
bug Something isn't working module-script Script module needs-discussion Issues to be discussed by the working group

Comments

@sadym-chromium
Copy link
Contributor

Currently, if the same context is set twice in the contexts param of the script.addPreloadScript command, the required scripts is added twice to that context. I wonder if this is correct and expected behavior, or we should throw exception / ignore the duplicate?
@sadym-chromium sadym-chromium mentioned this issue Dec 11, 2023
Merged
@whimboo whimboo added bug Something isn't working module-script Script module needs-discussion Issues to be discussed by the working group labels Dec 11, 2023
@whimboo
Copy link
Contributor

whimboo commented Dec 11, 2023

Do we actually have the same situation with session.subscribe and session.unsubscribe? I'm fine with ignoring duplicated entries by defining it maybe as a Set?

@sadym-chromium
Copy link
Contributor Author

I'm fine with set

@css-meeting-bot css-meeting-bot mentioned this issue Dec 13, 2023
Merged
@Lightning00Blade Lightning00Blade mentioned this issue Dec 14, 2023
Merged
@whimboo whimboo changed the title Clarify script.addPreloadScript behavior with a duplicated context in contexts Ignore duplicated contexts entries in script.addPreloadScript, session.subscribe and session.unsubscribe Dec 15, 2023
@Lightning00Blade Lightning00Blade linked a pull request Dec 19, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working module-script Script module needs-discussion Issues to be discussed by the working group
Projects
None yet
Milestone
No milestone
3 participants
@whimboo @Lightning00Blade @sadym-chromium