-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct support for avc3, hev1? #857
Comments
I think if its hev1/avc3, WebCodec should also include sps/pps/vps into the EncodedVideoChunk, so I dont need to extract codec description to get these parameter sets if they are changed. |
It looks more like a muxing issue rather than an encoding issue. VideoEncoder already provides two ways to get SPS, PPS, and VPS (avc and annexb). If a container needs these parameters to be in the bitstreams, it can either
|
Eugene reminded me offline that we always emit a new description when the config changes. So I think it would be acceptable for us to say that we never generate avc3/hev1 and instead always generate avc1/hvc1. We can either remove the avc3/hev1 codec strings or say something in the registry that they are treated as avc1/hvc1. |
I would remove the avc3/hev1 codec strings rather than treating them as avc1/hvc1. |
My feeling is that the options we provide, namely Providing the Based on the above logic, it seems that if WebCodecs is willing to supports the |
array_completeness
value which should be set to 1 if parameter sets are expected to change.The WebCodecs codec registry currently reports support for both of these forms. Should we remove that? Should we require implementations to set
array_completeness=1
for HEV1 content even if we don't allow in-band parameter set changes?@Djuffin @sandersdan
The text was updated successfully, but these errors were encountered: