Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs to WebAuthn methods should not include strict Enum types #1376

Closed
jcjones opened this issue Feb 26, 2020 · 2 comments · Fixed by #1392
Closed

Inputs to WebAuthn methods should not include strict Enum types #1376

jcjones opened this issue Feb 26, 2020 · 2 comments · Fixed by #1392

Comments

@jcjones
Copy link
Contributor

jcjones commented Feb 26, 2020

We need to audit all enums passed into WebAuthn to ensure that WebAuthn can be extended without causing WebIDL failures for lagging implementations.

What we did for Transport was to define that the input values be DOMString and coerced when possible into the acceptable enum values. At the 26-02-2020 face-to-face we agreed that in general, enums input into WebAuthn, if unknown, be treated as if the value was not set (e.g., the default value).

This affects #1366.

@nadalin nadalin added this to the L2-WD-03 milestone Feb 26, 2020
@equalsJeffH
Copy link
Contributor

on 2020-03-11 call: we just noted the verbal agreement we had that @agl to address the AttestationConveyancePreference enum as a part of completing PR #1366, and then @jcjones was intending to address the remaining enums in the spec.

@equalsJeffH
Copy link
Contributor

Note: PR #1366 now addresses changing PublicKeyCredentialCreationOptions.attestation to a DOMString.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants