Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "creating a feature policy" to use embedder #390

Open
domenic opened this issue Jul 7, 2020 · 0 comments
Open

Update "creating a feature policy" to use embedder #390

domenic opened this issue Jul 7, 2020 · 0 comments

Comments

@domenic
Copy link

domenic commented Jul 7, 2020

HTML calls "creating a feature policy" in https://html.spec.whatwg.org/#creating-a-new-browsing-context. However, the "creating a feature policy" algorithm asks whether it's operating on a nested browsing context. And, at the time that call is made, the browsing context is never a nested BC, because we're still in the process of creating it; we haven't set up the parent relationships.

whatwg/html#5583 we changed things a bit to make this setup more resilient. In particular whatwg/html@3511b20 fixed the analogous problem for the sandboxing flags.

Concretely, it looks like the algorithm should be updated to accept null or an element embedder, instead of a browsing context. And then it should pass that through to https://w3c.github.io/webappsec-feature-policy/#define-inherited-policy, which can just check if embedder is null or not, and if it is not, use embedder directly.

Then we'd update the HTML call site and remove the red box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant