-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More descriptive header names for destination
and user-activated
#9
Comments
I don't have strong feelings about the name. Something longer might be fine. That said, the header name isn't affected by HPACK, so extra bytes are something to consider. @mnot suggested I can see the argument that
That surprises me. From earlier conversations, it sounded like this was an important mitigation for XS Search? Did I misunderstand that? |
Re: header names, if there don't seem to be any significantly more appealing alternatives to what's currently in the spec, let's just stick to what we have -- there's probably not much benefit to bikeshedding this more :)
I obviously favor more security-relevant metadata to less, so I wouldn't argue for removing it; but it somehow seemed easier to justify it as one of many fields in It has security value for preventing XS-Search or tabnabbing, but these might also be tackled with |
I plan to leave the naming as-is. It's a compromise to be sure, but it feels like a reasonable one (and given the conversation in #16, it doesn't seem like this will block an initial pass at this feature anyway). |
Some of the shortened header names seem fairly cryptic. Would it make sense to rename them to make their purpose more obvious? For example:
Sec-Fetch-Dest
->Sec-Fetch-Destination
Sec-Fetch-User
->Sec-Fetch-User-Activated
orSec-Fetch-Gesture
?FWIW if the user-activated flag is the odd one out, I wouldn't be super sad to not have it in v1 -- it seems the least likely to be useful for developers in the short term.
The text was updated successfully, but these errors were encountered: