-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limiting to http/https is limiting #178
Comments
Maybe we need to mint a new absolute and relative URL string that excludes |
Excluding Working out what the right primitive is here isn't cheap. This is something that likely touches the HTML or infra specs if we do this right. But the advantage is that we are resting this on principles and a shared understanding. The ideal state is that this doesn't rely on just one implementation finding these problems, but everyone can benefit. Including apps that fetch resources and share them, because responsibility for this problem is a shared burden. Enough pontification though. Marcos has the right approach. |
Emailed public-webappsec for further input on this. |
So, from the emails to WebAppSec, I think what we could do is:
That should give us broad coverage, while allowing the UA to retain control over what's actually shared, while excluding the "bad ones". |
#173 was a bit of a learning experience. The fix for that in #174 limits URLs to http or https. That was the most conservative reaction to that issue.
This means that a number of URI schemes with no known exposure to this vulnerability can no longer be shared. From standard protocols mailto, sip[s], and tel are all examples of schemes that do not invoke actions and should be safe to share. (Why you might use those rather than share a vCard resource is not relevant; these seem valid to me.) Then there are the quasi-standard things like: ipfs, magnet. And a whole bunch of proprietary schemes: acrobat, zoommtg, steam, microsoft-edge (ok, maybe we don't want that...), and so forth.
Now that the dust has settled, it might be worth examining principles a little closer to determine whether a looser set of constraints can be made to work. @dveditz suggested that we block URLs if we might not permit both navigation or redirection. I think that is a reasonable starting point here. We don't allow navigation or redirects to
file://
and so sharing that seems to be primarily a means of circumventing that policy.We can't expect that share targets will respect the same policies that a browser does in case it follows an HTTP URL that redirects to file:///, but we are explicitly accepting that risk already by allowing use of HTTP schemes.
The text was updated successfully, but these errors were encountered: