Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic tests for Presentation API #3063

Merged
merged 11 commits into from
Jun 8, 2016
Merged

Basic tests for Presentation API #3063

merged 11 commits into from
Jun 8, 2016

Conversation

taff-franck
Copy link
Contributor

The following test was perform:

  • PresentationRequest with incorrect url
  • PresentationRequest with correct url
  • reconnect() with wrong Presentation ID

PresentationRequest constructor  test with incorrect url
PresentationRequest test with correct url
reconnect() test with wrong Presentation ID
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6548

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@zqzhang
Copy link
Contributor

zqzhang commented May 23, 2016

w3c-test:mirror

*/

test(function() {
assert_throws(new SyntaxError(), function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@louaybassbouss
Copy link
Contributor

@taff-franck in the Presentation API F2F Meeting we discussed also the way how we create Presentation URLs that are compatible with Google Cast Receivers and other Receiving UAs. We need to replace in all tests 'https://google.com/cast#__castAppId__=CC1AD845/__castClientId__=' + client_id; with 'http://w3c-test.org/presentation-api/receiving-ua/idlharness.html#__castAppId__=2334D33A/__castClientId__=' + client_id;. the Cast Id for http://w3c-test.org/presentation-api/receiving-ua/idlharness.html is in this case 2334D33A. This will work for now in Chrome canary https://www.google.com/chrome/browser/canary.html. Other Implementations like crosswalk from Intel will still work with this solution and the hash parameters will be ignored.

@zqzhang
Copy link
Contributor

zqzhang commented May 26, 2016

@louaybassbouss
Copy link
Contributor

@zqzhang agree relative URL is better if we want to run the tests from a local system and not from w3c-tests.org. @taff-franck please consider this comment.

var wrong_presentation_url = null;

/**
* Test if PresentationRequest constructor returns a SyntaxError() by missing presentation URL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/SyntaxError/TypeError/g

@zqzhang
Copy link
Contributor

zqzhang commented Jun 8, 2016

Thanks, LGTM.

@zqzhang zqzhang merged commit 895d734 into web-platform-tests:master Jun 8, 2016
arronei pushed a commit to arronei/web-platform-tests that referenced this pull request Jun 14, 2016
* PresentationRequest constructor  test with incorrect url
* PresentationRequest test with correct url
* reconnect() test with wrong Presentation ID
ivanzr pushed a commit to ivanzr/web-platform-tests that referenced this pull request Jun 29, 2016
* PresentationRequest constructor  test with incorrect url
* PresentationRequest test with correct url
* reconnect() test with wrong Presentation ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants