-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic tests for Presentation API #3063
Basic tests for Presentation API #3063
Conversation
PresentationRequest constructor test with incorrect url PresentationRequest test with correct url reconnect() test with wrong Presentation ID
Critic review: https://critic.hoppipolla.co.uk/r/6548 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
w3c-test:mirror |
*/ | ||
|
||
test(function() { | ||
assert_throws(new SyntaxError(), function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be TypeError
. See discussion at
https://critic.hoppipolla.co.uk/showcomments?review=3331&filter=all
@taff-franck in the Presentation API F2F Meeting we discussed also the way how we create Presentation URLs that are compatible with Google Cast Receivers and other Receiving UAs. We need to replace in all tests |
Can we use relative presentation URL? |
@zqzhang agree relative URL is better if we want to run the tests from a local system and not from w3c-tests.org. @taff-franck please consider this comment. |
var wrong_presentation_url = null; | ||
|
||
/** | ||
* Test if PresentationRequest constructor returns a SyntaxError() by missing presentation URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/SyntaxError/TypeError/g
Thanks, LGTM. |
* PresentationRequest constructor test with incorrect url * PresentationRequest test with correct url * reconnect() test with wrong Presentation ID
* PresentationRequest constructor test with incorrect url * PresentationRequest test with correct url * reconnect() test with wrong Presentation ID
The following test was perform: