From d5975dc652e7cb2f91e8d5fe797e7366d168878c Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Sat, 17 Oct 2020 11:07:39 +0100 Subject: [PATCH 1/4] Tweak `.change` styling Make it more visually obvious --- guidelines/guidelines.css | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/guidelines/guidelines.css b/guidelines/guidelines.css index ef3be40bf0..139f81303c 100644 --- a/guidelines/guidelines.css +++ b/guidelines/guidelines.css @@ -3,7 +3,13 @@ } .change { - display:inline; + display: inline; + color: #fff; + background: #e00; + border-radius: 0.25em; + padding: 0.25em; + margin: 0 0.25em 0 0; + font-weight: bold; } .new { From 7885c123142886d81715af95b9fbf3712ea15c7b Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Sat, 17 Oct 2020 11:22:28 +0100 Subject: [PATCH 2/4] Remove square brackets around change markers Not convinced this adds any majorly useful semantics - not read out by AT by default unless you go character by character, and it's not really needed to delimit the change marker which sits in its own little paragraph (i.e. it's not delimiting start/end of a whole section that's changed, or similar) --- script/wcag.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/script/wcag.js b/script/wcag.js index 92c4fb7ee5..c134390927 100644 --- a/script/wcag.js +++ b/script/wcag.js @@ -19,11 +19,6 @@ function linkUnderstanding() { } function addTextSemantics() { - // put brackets around the change marker - document.querySelectorAll('p.change').forEach(function(node){ - var change = node.textContent; - node.textContent = "[" + change + "]"; - }) // put level before and parentheses around the conformance level marker document.querySelectorAll('p.conformance-level').forEach(function(node){ var level = node.textContent; From 05558a6dd7149ad0192865ae4f2e69bd535d7a55 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Wed, 8 May 2024 14:28:57 +0100 Subject: [PATCH 3/4] Darken background for > 7:1 contrast --- guidelines/guidelines.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guidelines/guidelines.css b/guidelines/guidelines.css index 139f81303c..7a833bd546 100644 --- a/guidelines/guidelines.css +++ b/guidelines/guidelines.css @@ -5,7 +5,7 @@ .change { display: inline; color: #fff; - background: #e00; + background: #B50000; border-radius: 0.25em; padding: 0.25em; margin: 0 0.25em 0 0; From b92fd1420702553b7111248cb3b91e4e263f66b8 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Wed, 30 Oct 2024 15:51:32 +0000 Subject: [PATCH 4/4] Tweak padding subtly --- guidelines/guidelines.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guidelines/guidelines.css b/guidelines/guidelines.css index 8a8864433a..e7ca78324b 100644 --- a/guidelines/guidelines.css +++ b/guidelines/guidelines.css @@ -7,7 +7,7 @@ color: #fff; background: #B50000; border-radius: 0.25em; - padding: 0.25em; + padding: 0.25em 0.4em; margin: 0 0.25em 0 0; font-weight: bold; }