Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken anchors - Understanding Conformance #3064

Closed
luce-carevic opened this issue Feb 25, 2023 · 7 comments
Closed

Broken anchors - Understanding Conformance #3064

luce-carevic opened this issue Feb 25, 2023 · 7 comments

Comments

@luce-carevic
Copy link

Hi!

There are broken anchors on the Understanding Conformance new page.

Scope :

  • all the anchors "#dfn-[term]" for example "#dfn-web-page";
  • anchor on the word "technologies" (section Understanding Requirement 5)
@alastc
Copy link
Contributor

alastc commented Feb 27, 2023

@michael-n-cooper I assume this is a generator issue (the definitions in the content don't work).

Either the definitions need adding to the page (which seems to be the case, see #3066), or they should go to the versions in the index page.

@EricDunsworth
Copy link
Contributor

There are also various placeholder links (e.g. <a>link</a>) throughout that page.

For example, the understanding conforming alternate versions section's "functionality" and "human languages" links have CSS hover effects, but can't be activated.

The equivalent links in WCAG 2.0's version of that section point to the glossary section in WCAG 2.0's main page. Their anchor destinations are formatted as #[term]def .

@fstrr fstrr assigned iadawn and unassigned michael-n-cooper Mar 26, 2024
@fstrr
Copy link
Contributor

fstrr commented Mar 26, 2024

This issue is now on the 2.1 and 2.2 versions of the site.

Links in the "Page Contents" sidebar work, but inline links starting with #dfn- don't.

I've checked the 2.0 version of this page to find out where links should be going to and think this is likely a templating issue.

@patrickhlauke
Copy link
Member

Indeed it's a template issue ... in essence, when normative SC wording contains links to definitions, they work fine when in the spec (since the spec itself has all the definitions included at the end), but when the SC fragment itself is pulled into the understanding documents, the definitions aren't always pulled into the final understanding page that's being generated. /cc @iadawn

@fstrr
Copy link
Contributor

fstrr commented Mar 26, 2024

There are some id attributes in the page's HTML that can be updated to make some of the links work, but that doesn't fix the whole page, and I didn't want to put in a "half a job" PR.

@kfranqueiro
Copy link
Contributor

This was resolved for 2.2 by #3917; it will be resolved for 2.1 when we can re-generate docs for that version with the new build system.

@kfranqueiro
Copy link
Contributor

This is resolved for 2.1 as well now that WCAG 2.1 informative docs have been republished via the new build system, made possible via #4007.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants