-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus-appearance and Non-text-contrast relationship #1490
Comments
For what it's worth, I'm in favour of any streamlining or simplification to the Non-Text Contrast issue. Regarding this quote...
Would you leave in hover state in the WCAG 2.2 interaction of 1.4.11? |
@wardav hover is more or less removed from 1.4.11 already: |
If I understand correctly the current 3rd bullet is being proposed to address the possibility of a focus ring that is similar in colour to the button and therefore when the focus lands on that component, the indication of focus is more subtle, and may be difficult for some to see. My concern is the following
|
If you mean the C40 technique, I don't know why it should no longer be valid. Only the size of the indicator might have to be adjusted, but the technique itself is still good. Just because 2 colors are used, the 3rd bullet is not relevant for C40. By the way, the fact that the size of the indicator may need to be adjusted also applies to all other focus techniques. |
@JAWS-test |
The update to the 3rd bullet from today (merged) is:
The impact that has really depends on your background colours, if they are all light(ish) or dark(ish) then it's pretty straightforward. If you want to see the example from the meeting, open this codepen in Edge (or Chrome if that's updated as well). As an example, this is essentially a triple colour indicator (light/dark/light) that works across both backgrounds. The key code from that is: But you don't have to do that, you could use:
Personally, working with design teams I've had the best success with the approach of: one for light backgrounds, one for dark backgrounds. |
Closing this issue as it was discussed during the meetings and we merged in the proposed changes. |
During the group discussion on 27th Oct there was discussion (triggered by #1403) about the need for the 3rd bullet:
The question was: Do we need this consider non-text contrast overlaps?
(Chair hat off now)
We've had quite a few discussions & resolutions on Non-text contrast since WCAG 2.1 was publish, picking a few relevant ones:
The understanding document states under Adjacent Contrast:
Then from the relation to 2.4.7 section:
Those changes came from issues like:
My argument is that Non-text contrast only measures "adjacent colors" outside of the component, therefore it is not suitable for focus-styles. We cannot ask for Non-text contrast to apply to both the component against the "background" (adjacent colors to the component) and the focus-indicator with the current language. (Particularly as it applies to all 'states', so doesn't differentiate from hover etc.)
That is why we approved in August this addition to the understanding doc:
So my proposal is that in WCAG 2.2 we remove the overlap from 1.4.11 and rely on the new SC to cover focus styles (leaving the 2.1 version of non-text contrast as it is).
I proposed updating the 3rd bullet to match the one above, so the complete SC would be:
Also, during the discussion we were wondering about the adjacent colors when it comes to, for example, a contrasting outline that also has a halo around that, e.g.
(Codepen for the source code)
In this case the orange outline meets the first two bullets and contrasts with the button itself. However, the presence of the yellow halo means it is not contrasting with all adjacent colors.
I propose that we tackle this in the understanding, in a similar way we have in non-text contrast:
So for focus-appearance, that would be something like:
"If the focus indicator uses several colors, any color which does not interfere with identifying the indicator can be ignored for the purpose of measuring contrast ratio. For example, a 3D drop-shadow on a focus indicator is considered to be subsumed into the color closest in brightness (perceived luminance). If the size is uncertain, calculate the minimum size based on the area which meets the contrast change requirement."
The text was updated successfully, but these errors were encountered: