-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGWG feedback: Text has minimum/enhanced contrast #226
Comments
ACT Task Force Response (approved)On using highest possible contrastACT Rules test for failure conditions. The way this works is that failing these rules means their corresponding success criterion is not satisfied. However passing the rule still requires further testing. This is described in the Accessibility Requirements section on the rule page. ACT takes its interpretations from WCAG documentation. Without an unambiguous description of how to find appropriate foreground and background colors, the question of what color values to use is left open to interpretation. Some testers are stricter than others on how these contrast is measured. When these rules were originally written lowest contrast was considered, but rejected because there were too many open questions about how to test contrast consistently without false positives. Examples of such questions include:
These are questions we did not feel equipped to answer. To avoid failing success criteria that shouldn't be we decided to use highest possible contrast. Wording of contrast levelsWe have updated the rule to use the following wording:
OtherTo Mike Gower
To Gundula NiemannThe "Human language" exception comes directly from WCAG's definition of text, which says:
We do believe mathematical formulas meet the definition of human language:
To MakotoThank you for the suggestion. We have opened an issue to make the rule stricter when measuring contrast on CJK characters. As not having this doesn't seem to produce false positives, we believe this shouldn't prevent the rule from getting published. To DetlevACT Rules hold true for whatever state a page is in as it is being tested. Ensuring a page is tested in different states and viewport sizes is the responsibility of a tester. As the Contrast criteria do not include explicit requirements on which viewport sizes to test in, this should not be included in by the rule either. |
In the example questions:
Fix "the" to "they" |
Regarding Gregg's third concern about text with a mixed background where part of the character passes and part of the character fails, the rule includes Failed Example 3. Also, in last sentence in response To Detlev: remove the words "is" and "by"
|
We have some guidance on testing each pixel next to letters in this sufficient technique ttps://www.w3.org/WAI/WCAG21/Techniques/general/G18 In addition, I would prefer to say "lowest contrast" text rather than highest. Highest would mean that it only takes one contrast pixel for the whole letter to pass. Another option is to go with the approach from 1.4.11 and that is to say if you were to remove the non-contrasting portions could you still tell what the letter is? If so, it could pass. If not - it fails. |
@mraccess77 Two pixels from the edge of the letter doesn't seem to work. That includes things that should obviously not be considered background, like other letters, underlines, icons, etc. But there are also lots of grey areas here, like 3D letter effects, small shadows on one side of the text, strike-through, non-overlapping adjacent images, etc. I certainly think looking at the shape of letters after the low-contrast portions are removed is worth exploring. I don't think ACT Task Force is the right group to work on that. That doesn't fit our work statement and we don't have the right people do to that kind of work, but if LVTF or some other group in AGWG were to come up with recommendations in that area, we would definitely look at that and try to incorporate it in the rules. I think that would still be difficult to do consistently. What letters I recognize with parts hidden might be very different from what you do, or from what different machine vision algorithms do. Still, we'd certainly see if it could be used to make the rule stricter. The more important question for AGWG I think is do we want to just have no rules covering color contrast until someone finds a good solution for this, or can we make due with a rule that cover 95% of all cases (one text color, on one background color, with some aliasing between) and accept that some edge cases are left as "further testing needed"? |
The thing I'd like to avoid is setting a precedent of "Highest Possible Contrast as this seems to contradict with the technique G18. The decisions on what conforms to WCAG falls to AG but some could construe that this rule makes that practice de facto. I would be ok if we could add some text clarifying that a pass of this rule may not mean a conformance of the SC - which I think we sort of allude to with the statement on passes requiring additional testing of the SC. From a practical testing standpoint I understand we do need to come up with a test that is reasonable. |
This is mentioned in these rules in two places. First in the background, and then in the accessibility requirements section:
...
These two sections are where this information would normally go. Can you suggest improvements that we could make here that would address your concern? |
Perhaps we could tweak this part "There is no clear method for determining legibility, which is why this is out of scope for this rule." |
I opened a PR ☝️ |
Response has been accepted with the amended rule. |
Source:
On using highest possible contrast
Wording of contrast levels
Other
The text was updated successfully, but these errors were encountered: