Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Grid and 2 Landmark pages lead to 404 when accessed via redirects due to casing of file names #192

Closed
mcking65 opened this issue Feb 13, 2023 · 4 comments
Assignees
Labels
bug Something isn't working Infrastructure

Comments

@mcking65
Copy link
Contributor

mcking65 commented Feb 13, 2023

We have 4 legacy URLs that still lead to 404 errors.

Data Grids Example Page

because people could be bookmarking the current functional location, it seems like we should change the redirect to point to the functional location. Then, we land Pull Request #2597 and add another redirect to the renamed file.

Layout Grids example page

because people could be bookmarking the current functional location, it seems like we should change the redirect to point to the functional location. Then, we land Pull Request #2597 and add another redirect to the renamed file.

Landmark Examples: HTML Sectioning Elements page

Should we leave the redirect as is and rename content/patterns/landmarks/examples/HTML5.html to content/patterns/landmarks/examples/html5.html? Perhaps add this change to w3c/aria-practices#2597?

Landmark Examples: General Principles page

Is the best solution to change the redirect to point to functional location 1?

@alflennik wrote:

I looked into the datagrids and layout grids a little bit more and found that the WAI website seems to automatically remove capitalized letters from URLs. This is why the links on the site work but bookmarked pages don't.

I think the pages already have a bit of a strange naming convention, given that no other pages have capitalized letters, so a good solution would probably be to rename those two files in the aria-practices repo and introduce new redirects from the old urls to the new ones.

Originally posted by @alflennik in #186 (comment)

@a11ydoer
Copy link

@alflennik can you share the order of actions you mentioned at the APG meeting on 2/14/2023?

@alflennik
Copy link
Contributor

@mcking65 @a11ydoer we can safely merge w3c/aria-practices#2597 and following that I will create a new publication branch, inform the WAI team, and document the changes we need to make to the redirects.

@alflennik
Copy link
Contributor

@mcking65 shall we close this issue following the deploy last week?

@mcking65
Copy link
Contributor Author

Yes. Closed by w3c/aria-practices#2597 and #200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants