From 97a894b2e006dd8ae6aba8705039ed7837cc1ec6 Mon Sep 17 00:00:00 2001 From: Benjamin Young Date: Tue, 2 Apr 2024 10:20:12 -0400 Subject: [PATCH] Rename testAllImplementers to testAllImplementations. Matches what actually is happening...and what I kept typing... --- README.md | 4 ++-- implementations/index.js | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index a8c8399..88651b3 100644 --- a/README.md +++ b/README.md @@ -136,7 +136,7 @@ Additional test suite runtime configuration can be done via the `settings` key in a `localConfig.cjs`. The current global settings are: * `enableInteropTests` - enable/disable the cross-implementation "interop" tests - * `testAllImplementers` - enable/disable testing _all_ implementations (not + * `testAllImplementations` - enable/disable testing _all_ implementations (not just what's in `localConfig.cjs`) Both of these settings are `false` when `localConfig.cjs` is present, but may be @@ -147,7 +147,7 @@ module.exports = { "settings": { // overriding the default, false, for local testing "enableInteropTests": true, - "testAllImplementers": true + "testAllImplementations": true }, "implementations": [{ "name": "My Company", diff --git a/implementations/index.js b/implementations/index.js index dd49bdb..8a84765 100644 --- a/implementations/index.js +++ b/implementations/index.js @@ -31,10 +31,10 @@ const localConfig = getLocalManifest('localConfig.cjs'); export const localSettings = (Object.keys(localConfig).length > 0) ? // we have a localConfig object, so merge in local defaults {...localConfig?.settings, - ...{enableInteropTests: false, testAllImplementers: false}} : + ...{enableInteropTests: false, testAllImplementations: false}} : // otherwise, return the global defaults // FIXME: ...consider renaming `localSettings` as it can hold global ones... - {enableInteropTests: true, testAllImplementers: true}; + {enableInteropTests: true, testAllImplementations: true}; // get localConfig and look for an implementations property const local = localConfig?.implementations || []; @@ -44,6 +44,6 @@ const all = remote.concat(local); // if local implementations are defined only return local implementations export const implementerFiles = local.length ? - // unless testAllImplementers is true...in which case, include them all - (localSettings.testAllImplementers === true ? all : local) : + // unless testAllImplementations is true...in which case, include them all + (localSettings.testAllImplementations === true ? all : local) : all;