-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in the context file? #1373
Comments
@iherman fwiw, @gkellogg's Distiller creates these n-quads from the same JSON-LD...so there may indeed be a bug in the playground. Here are the n-quads from the Distiller--which match what you were after: _:g524580 <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <https://www.w3.org/2018/credentials#VerifiablePresentation> .
_:g524580 <https://www.w3.org/2018/credentials#verifiableCredential> _:g524600 .
<http://university.example/credentials/1872> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <https://www.w3.org/2018/credentials#VerifiableCredential> _:g524600 .
<http://university.example/credentials/1872> <https://www.w3.org/2018/credentials#issuer> <https://university.example/issuers/565049> _:g524600 . I'll do some more direct testing with |
Phew. From the point of view of VCDM I am relieved (and also from the point of view of my own understanding...). @msporny @brentzundel I am not sure whether we want to close this issue (being irrelevant for the VCDM spec) or leave it open until is handled, to avoid errors in discussions like in #1358 (comment) or #1358 (comment). I leave this decision to you. In any case, I removed the before-CR label. |
I suspect it's a bug in handling scoped context in jsonld.js. Looking at the credentials/v2 context definition:
For some reason, jsonld.js does not seem to interpret the value of |
FWIW, Sophia, which is based on @timothee-haudebourg's JSON-LD library, also parses this correctly: example. |
There was missing JSON-LD test coverage for this use case and a jsonld.js bug. A JSON-LD test suite test was submitted, jsonld.js patched, and the json-ld.org playground was updated. It should work as expected now. |
The issue was discussed in a meeting on 2023-12-06
View the transcript2.8. Bug in the context file? (issue vc-data-model#1373)See github issue vc-data-model#1373. Brent Zundel: I think this one is before CR.
Orie Steele: I would like some elaboration to be in the minutes: could someone explain the essence of the bug? Dave Longley: It's not that we have a bug in our context file. It's that we added terms to make v1 VCs compatible with v2 Verifiable Presentations.
|
The bug has indeed been handled and the example works as expected. This means that the issue turned out not to be in our |
Consider a skeleton VP content:
per specification, the N-quads equivalent should be something like (I use CURIEs to make it more readable):
However, what I get on the playground:
i.e., the "enclosing" graph does not appear.
This is either a bug in the
@context
file or the playground. If the former, it is the WG's job to solve it...Do I miss something?
@dlongley @BigBlueHat @davidlehn @pchampin
The text was updated successfully, but these errors were encountered: