Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to the revoked property #182

Closed
OR13 opened this issue Aug 26, 2023 · 3 comments
Closed

Adjustments to the revoked property #182

OR13 opened this issue Aug 26, 2023 · 3 comments
Assignees
Labels
before CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists A pull request exists to address this issue.

Comments

@OR13
Copy link
Contributor

OR13 commented Aug 26, 2023

Multikey defines revoked but JsonWebKey does not.

"revoked": {
  "@id": "https://w3id.org/security#revoked",
  "@type": "http://www.w3.org/2001/XMLSchema#dateTime"
},

On w3c/vc-jose-cose#144 (comment) @TallTed asks if this field should include TZ.

If we make such a change, we would want to ensure it applies to all Verification Method classes, and was documented the same in both specs.

@msporny
Copy link
Member

msporny commented Aug 26, 2023

we would want to ensure it applies to all Verification Method classes, and was documented the same in both specs.

Agree.

For the time being, I'll just bring both VM classes inline w/ each other.

@msporny msporny self-assigned this Aug 26, 2023
@msporny msporny added before CR This issue needs to be resolved before the Candidate Recommendation phase. ready for pr This issue is ready to be resolved via a pull request labels Aug 26, 2023
@msporny
Copy link
Member

msporny commented Aug 26, 2023

PR #184 has been raised to address this issue. This issue will be closed once PR #184 is merged.

@msporny msporny added pr exists A pull request exists to address this issue. and removed ready for pr This issue is ready to be resolved via a pull request labels Aug 26, 2023
@msporny
Copy link
Member

msporny commented Sep 2, 2023

PR #184 has been merged, closing.

@msporny msporny closed this as completed Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists A pull request exists to address this issue.
Projects
None yet
Development

No branches or pull requests

2 participants