Skip to content
This repository has been archived by the owner on Sep 19, 2018. It is now read-only.

Attempt to dump offending objects in assert_array_equals and assert_object_equals #227

Closed
pwnall opened this issue Dec 19, 2016 · 1 comment

Comments

@pwnall
Copy link
Contributor

pwnall commented Dec 19, 2016

Both assert_array_equals and assert_object_equals check their arguments piece by piece (element by element / property by property). This approach is sufficient when the assertions pass, but has a side-effect that when the assertions fail, we get sub-optimal debugging information.

Please consider building the assertion failure messages for these two functions in a more deliberate way. For example, when comparing two arrays, I'd like to see their elements in a JSON-like output (bonus points for GitHub-like diff highlighting).

Solving this issue would make it easier to use WPT to understand the differences in browser behaviors, and to debug & fix interoperability issues. Thank you very much!

@wpt-issue-mover
Copy link
Collaborator

This issue has been moved to web-platform-tests/wpt#7179; please continue all discussion there.

@w3c w3c locked and limited conversation to collaborators Aug 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants