-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and Share Project Outputs benefits #51
Comments
Thanks for this @chrisn. Agreed this should be re-written to match the Success Criteria. I'll get onto this. |
Where can I see the changes? There's no update in the commit history here. |
The changes will be made available when the next draft is published (we go through several internal review processes for quality control so we don't simply commit changes to the master branch at regular intervals). However, if you wanted a preview:
Feel free to provide any feedback below! |
I'd suggest adopting a process where changes are visible, e.g., on development branches - and PRs that can be reviewed by the community. |
Environmental - These claims seem tenuous at best. |
@chrisn This is something I am actively exploring for sure. We use a format called ReSpec and the final format (which everyone sees online) is exported into it's dependency-free HTML form. This would make merging changes into the main branch tricky. One solution I've been moving toward is to have the ongoing development document available as a separate concern to the finalized form, thereby it should allow both a DEV and FINAL draft version to be visible at all times (and allow individuals to contribute easier via pull requests). It's something I'm bringing up at this months meeting to hopefully get in place as soon as possible. RE your feedback: I agree that further work needs to be done on some of these so I'll redraft them though on your first point I will make this point: If an individual spends less time in front of a screen, there are clear energy savings (whether a developer or a user). Being able to understand code, documentation, or other material provided in-house or by third-parties will take time and thereby, the less friction which occurs, and the less effort involved, the more savings in effort and energy. If it can be accepted as a matter of economy that simple systems save money, it should be by comparison relatively straight forward as a parable to identify that by association, emissions savings will also occur (even support costs have emissions). |
I think there are more systemic issues at play here, but we'll raise a separate issue on that. |
If you have a list of benefits that you believe would best replace the existing ones, I'd be more than happy to include them in the next draft (we are all volunteers so your contribution would be very much welcome). |
I've taken another shot at the listed benefits taking into account your above comments:
Hope this addresses the issue better! |
I think the only real benefit here is the Economic one, potentially also Conversion. With Accessibility, I see you've rephrased this as a recommendation, but the Benefits sections should list the beneficial outcomes of following a recommendation, rather than setting new recommendations. I suggest that if a guideline has no effect in a particular category, then we can simply omit that category (as is done elsewhere). |
I still think there is a solid case on the environmental benefits (however systemic and as part of wider variables it encompasses) for the reasoning based upon my earlier comments. However I accept that the performance and accessibility are less tenable so I'll remove them from the guideline on that basis leaving just the three in place. |
I have made the changes within the specification, however as you have requested this issue remain open I will keep it this way for the moment. Once the next draft is published and PR's are available this issue can always be closed with any further changes directly made through the living drafts (which will become available on the week of the 27th). |
The benefits listed in the Document and Share Project Outputs describe potential impacts of applying a design system ("reduce redundancy within code", "decreases the potential that your audience will have issues", "improves overall performance", etc) but don't address the requirement of this section, i.e., that "Everything produced [...] should be in an open format, well maintained, and curated in a common format (so everyone is working from the same model)."
Those benefits should be covered elsewhere in the document (and may already be covered, I'm still reading), and a list of benefits written that directly addresses the requirement of this section.
The text was updated successfully, but these errors were encountered: