Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setBaseAndExtent and other setter methods on Selection work with shadow DOM #99

Open
rniwa opened this issue Nov 6, 2018 · 3 comments

Comments

@rniwa
Copy link
Contributor

rniwa commented Nov 6, 2018

Per WICG/webcomponents#79, we should make setBaseAndExtent and other methods work with shadow DOM. Namely, when a node inside a shadow tree is given to setBaseAndExtent, it shouldn't throw or adjust the end points to be in the same tree.

@rniwa
Copy link
Contributor Author

rniwa commented Jul 20, 2023

At least collapse working with shadow DOM is a web compatibility requirement at this point:
WebKit/WebKit@c48d719

@annevk
Copy link
Member

annevk commented Jul 25, 2023

Hmm, so when a shadow tree child is selected it's exposed through a global API? That seems rather bad.

@rniwa
Copy link
Contributor Author

rniwa commented Jul 25, 2023

No, it's not exposed. It's just that these setter functions need to allow referencing into nodes within shadow trees. Getters will continue to return the outer most host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants