-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should redirected navigations have a workerStart value if a previous redirect URL was intercepted #118
Comments
Yes. Good catch, we should update processing (step 8) to reset it to 0 if timing allow check fails.
If TAO check passes we show timestamps for the "final resource in redirection", and 0's otherwise. So, in the example above it would be timestamps for c.com and Does that make sense? /cc @toddreifsteck |
Ok, thats not what the current WPT test verifies: And I guess its not what chrome does since it passes this test: https://wpt.fyi/service-workers/service-worker/resource-timing.https.html |
OK, so if I'm reading this correctly, in order to resolve this we need to:
(1) seems like a no brainer, so might be worthwhile to spin it off. @igrigorik - I remember a plan to better expose full redirect chains, but can't find an issue tracking it. Am I remembering correctly? |
@yoavweiss you're looking for #21. |
Following discussion on the last call, I believe both issues here (TAO & last redirected SW) are only impactful/observable in the NavigationTiming case. I'll open an issue there and close this one. |
Opened a couple of issues on NT, so closing this one |
Reopening as we missed a case where this does impact RT - iframe RT entries. |
Consider the following situation:
Two questions:
a. Should there be a
.workerStart
for the a.com interception? There would if this was a subresource request.b. Should the
.workerStart
value be controlled by theTiming-Allow-Origin
header? The redirectStart/redirectEnd values are controlled by that header, but workerStart doesn't mention it.If the answer to (a) is "yes", then consider:
Should the workerStart for a.com or b.com be shown?
The text was updated successfully, but these errors were encountered: