-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merchant-specified default shipping address #653
Comments
Ok, we might need to split this up into more parts to deal with email, phone number, etc. so let's do that separately. I'll start by with adding the constructor to Kinda crying now that it's called PaymentAddress as this will be useful throughout the web platform. Too late to rename? We can deal with that later. |
I've started working on this... but have questions about how crazy we want to go with the E.164 conformance. Playing with the libphonumber demo, it seems to be much stricter than what E.164 requires. e.g., if I'm reading E.164, "+" is optional. We can come up with a subset, like must start with "+", be at least 3 digits long, and have no more than 15 digits. And we canonicalize that by collapsing white space and "-". |
Modified the canonicalization proposal above to include removing "-". So, Additionally,
We should also look at historical discussion around |
|
It's worth noting that |
Unlike input, I also think it's workable to require E.164 formatted number, as we are putting the burden on the merchant (instead of the user!) to make sure the number is correctly formatted. If they know the address already (including country), they should be able to format the phone number correctly. |
Just noting that if we are going to specify allowing a default address, we might as well allow a suggested address when validation of a shipping address fails, as per #537. That is, we should specify something that works for both. I'm still wondering if we should allow just one suggested address or a set of them? |
Speaking to Editors, we want to push this to a future version of the spec. |
Does that mean postpone to after the v1 Recommendation, but still in charter for the WG? Ian |
Yes, precisely. We can still work on it in parallel tho (resources permitting). |
Noting WebKit implementation: https://trac.webkit.org/changeset/226766 |
Are you sure that's the correct link? I don't see address related changes in that commit |
Oops, the link was for merchant validation. Thanks! |
Noting this comment here: braintree/braintree-web#357 (comment) |
This issue was raised in Payment Request, but closed once we removed addresses from that API. We anticipate adding addresses back to the specification and so are re-opening this issue proactively. |
We added addresses back to the specification in the 7 August 2024 CRD |
At TPAC we've talked about merchant defining the default shipping address as a requirement for some implementers or merchants. I'm in favor of this feature. Should we also allow specification of other fields? For example, name, email, phone number. Even basic-card related data is conceivable here, but I'm not sure whether any merchant would use that.
cc: @marcoscaceres @aestes @michelle-stripe @jenan-stripe
The text was updated successfully, but these errors were encountered: