Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to specify CanMakePaymentEvent.respondWith() behavior #295

Open
romandev opened this issue Apr 16, 2018 · 1 comment · May be fixed by #296
Open

Need to specify CanMakePaymentEvent.respondWith() behavior #295

romandev opened this issue Apr 16, 2018 · 1 comment · May be fixed by #296

Comments

@romandev
Copy link
Member

We already added CanMakePaymentEvent to our spec but missed respondWith()'s behavior. In general, we understand how it works, but we need to define in more details in terms of spec. Otherwise, it might make some security holes.
@romandev romandev linked a pull request Apr 16, 2018 that will close this issue
Open
2 tasks
@stpeter
Copy link

stpeter commented Apr 16, 2018

@romandev What are the security issues? It's always good to document those so we can add them to security considerations section of the spec, and demonstrate the mitigations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define CanMakePaymentEvent.respondWith() behavior romandev/payment-handler
2 participants
@stpeter @romandev