Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to reuse web app manifest ImageResource better. #287

Closed
rsolomakhin opened this issue Apr 12, 2018 · 4 comments
Closed

Need to reuse web app manifest ImageResource better. #287

rsolomakhin opened this issue Apr 12, 2018 · 4 comments

Comments

@rsolomakhin
Copy link
Collaborator

Feedback on Payment Handler TAG review by @dbaron:

ImageObject is similar to web app manifest's ImageResource, but it: (1) doesn't have the two last properties, (2) has a differing type for type (DOMString vs. USVString).

IMHO, we should reuse web app manifest's ImageResource verbatim to ease both spec authoring and implementation.

@domenic
Copy link

domenic commented Apr 12, 2018

This is a dupe of #238, where I noted that I think it's actually not a good idea.

@rsolomakhin
Copy link
Collaborator Author

@dbaron: Would you agree with @domenic's logic in #238?

@kenchris
Copy link

I wouldn't. Platform and purpose are hints, so I don't see why they don't apply, for the same reason they exist in the web app manifest

@ianbjacobs
Copy link
Contributor

SInce this is a dupe of #238 I am going to close this issue and ping David Baron on that thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants