-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PaymentInstruments .set() and icons #233
Comments
When should icon processing happen? |
At display time, I think. We should do some light validation checks here. Working on a proposal. |
We would probably want to have some kind of caching to reduce |
Potentially, yeah... that's a tricky one. We need to check what the Notifications API does. |
Sounds good. I'm all for re-using existing paradigms, if Notification API has it all figured out already. |
Let me cross reference to a related issue here. |
The
.set()
algorithm has a whole bunch prose about icon processing. However, I don't think that is the right place to do any of the processing specified there.We should have a dedicated section for displaying icons, but storage of a payment instrument should just store the instrument, and not do any icon processing.
The text was updated successfully, but these errors were encountered: