Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaymentInstruments .set() and icons #233

Open
marcoscaceres opened this issue Nov 28, 2017 · 6 comments
Open

PaymentInstruments .set() and icons #233

marcoscaceres opened this issue Nov 28, 2017 · 6 comments

Comments

@marcoscaceres
Copy link
Member

The .set() algorithm has a whole bunch prose about icon processing. However, I don't think that is the right place to do any of the processing specified there.

We should have a dedicated section for displaying icons, but storage of a payment instrument should just store the instrument, and not do any icon processing.

@rsolomakhin
Copy link
Collaborator

When should icon processing happen?

@marcoscaceres
Copy link
Member Author

At display time, I think. We should do some light validation checks here. Working on a proposal.

@rsolomakhin
Copy link
Collaborator

We would probably want to have some kind of caching to reduce paymentRequest.show() latency due to loading the icons.

@marcoscaceres
Copy link
Member Author

Potentially, yeah... that's a tricky one. We need to check what the Notifications API does.

@rsolomakhin
Copy link
Collaborator

Sounds good. I'm all for re-using existing paradigms, if Notification API has it all figured out already.

@agektmr
Copy link

agektmr commented Feb 8, 2018

Let me cross reference to a related issue here.
cc: @kenchris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants