Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify spec and tests with respect to redirect info #158

Closed
npm1 opened this issue Sep 22, 2021 · 3 comments
Closed

Clarify spec and tests with respect to redirect info #158

npm1 opened this issue Sep 22, 2021 · 3 comments
Assignees

Comments

@npm1
Copy link
Contributor

npm1 commented Sep 22, 2021

Currently the Fetch spec sets redirectCount to 0 if there are any cross origin redirects in the chain to navigate. However, there seems to be no special treatment for redirectStart/redirectEnd. So what this means is that per the spec they should be set if the navigation passes all TAO checks (is it entirely clear what this means?). However, we added a test (navigation-timing/nav2_test_redirect_chain_xserver_final_original_origin.html) where we check that even if TAO checks pass, as long as there is a cross origin redirect, the timestamps are not exposed. We need to reconcile the spec and the test.

@noamr
Copy link
Contributor

noamr commented Sep 23, 2021

The handling of redirectStart and redirectEnd happens in the FETCH spec, https://fetch.spec.whatwg.org/#finalize-and-report-timing. Yes, currently there is no special treatment for navigation with the redirect timing properties, they behave the same as regular resource. Was that in the original spec and disappeared, or was it something that existed only in the tests?

@noamr noamr self-assigned this Sep 23, 2021
@noamr
Copy link
Contributor

noamr commented Sep 23, 2021

Actually from reading this again, navigation timing doesn't call finalize and report timing, which means that you are correct and this is missing in the spec - cross-origin redirects are not handled in the navigation timing spec. Assigning to myself.

@noamr
Copy link
Contributor

noamr commented Mar 20, 2022

This is now handled.

@noamr noamr closed this as completed Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants