Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new entry type for navigations from the BFCache #118

Closed
philipwalton opened this issue Oct 18, 2019 · 5 comments
Closed

Add a new entry type for navigations from the BFCache #118

philipwalton opened this issue Oct 18, 2019 · 5 comments

Comments

@philipwalton
Copy link
Member

Based on discussion around #115, both at TPAC and on the most recent call, I think it would make sense to have a separate navigation entry type that is dispatched when a page comes out of the BFCache.

Currently Safari will update the values of performance.timing, and Firefox will change the navigation.type value on the already-dispatched entry. But both of these are problematic if code on the page has local references to the original values (which I've seen example of), so dispatching a brand new entry type seems like the safest option.

Also, since the only way to currently tell that a page is coming out of BFCache is to listen to the pageshow event (and inspect event.persisted), sites that only care about BFCache navigations in order to measure them wouldn't need to listen to an additional event handler to detect when that happens.

@npm1
Copy link
Contributor

npm1 commented Jan 21, 2020

I believe the discussion from a WebPerf WG call not too long ago was to not implement this, for the time being. The decision was to attempt standardizing the timestamp they want on the pageshow event timeStamp attribute. Should we close this for now?

@philipwalton
Copy link
Member Author

Yes, happy to close this, but do we have another issue to track standardizing the timestamp for the pageshow event?

@npm1
Copy link
Contributor

npm1 commented Jan 21, 2020

Ahh yea this is why AIs from calls should have owners :) I don't think any issue has been filed, so I'll file one and then close this one.

@philipwalton
Copy link
Member Author

Great, thanks!

@npm1
Copy link
Contributor

npm1 commented Jan 21, 2020

Filed whatwg/html#5226, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants