Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presenting slides actions #284

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Add presenting slides actions #284

merged 1 commit into from
Sep 13, 2022

Conversation

beaufortfrancois
Copy link
Contributor

@beaufortfrancois beaufortfrancois commented Aug 17, 2022 •
edited by pr-preview bot
Loading

This PR adds new presenting slides actions as discussed in #274 (comment)

It does not add processing rules that allow them to be invoked from Capture Handle Actions yet.

Preview | Diff

@beaufortfrancois beaufortfrancois mentioned this pull request Aug 17, 2022
Closed
@youennf
Copy link
Contributor

youennf commented Aug 17, 2022

This PR adds new presenting slides actions as discussed in #274 (comment)

This looks good to me.

It does not add processing rules that allow them to be invoked from Capture Handle Actions yet.

My understanding is that MediaSession should/will not talk about Capture Handle Actions.
Instead Capture Handle Actions spec will refer to MediaSession actions and to some algorithms defined in MediaSession spec.
https://w3c.github.io/mediasession/#handle-media-session-action seems for instance interesting, though we might want to pass the target MediaSession as an additional parameter.

@beaufortfrancois
Copy link
Contributor Author

@steimelchrome Can you review as well?

jan-ivar
jan-ivar approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@jan-ivar jan-ivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks!

@steimelchrome
Copy link
Contributor

LGTM. Thanks!

@youennf youennf merged commit 52b1a55 into main Sep 13, 2022
github-actions bot added a commit that referenced this pull request Sep 13, 2022
@beaufortfrancois @github-actions
Add presenting slides actions (#284)
2550158 
SHA: 52b1a55
Reason: push, by @youennf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youennf youennf youennf approved these changes

@jan-ivar jan-ivar jan-ivar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beaufortfrancois @youennf @steimelchrome @jan-ivar