Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we support audio? #69

Closed
henbos opened this issue Aug 24, 2018 · 3 comments
Closed

Should we support audio? #69

henbos opened this issue Aug 24, 2018 · 3 comments

Comments

@henbos
Copy link
Contributor

henbos commented Aug 24, 2018

"1. Introduction" says that the document says is primarily concerns itself with video, but that the general mechanism here could be extended to audio and depth.

Does this mean we should ignore audio:true or define what to do in this case?
If we want to support audio we should support MediaTrackConstraints (#67).

If we support audio I think we should make it simple, and either share all audio being played out or none of it. Filtering out audio on a per-window basis does not make sense the way that display medias do. I think it would confuse the user as to what is or is not shared and have no practical uses.

We could also not support audio, in which case we should decide whether to ignore it or throw an exception, we need to be consistent (#68).

@uysalere
Copy link
Contributor

There is already some discussion on #61 about this.

@aboba
Copy link
Contributor

aboba commented Aug 30, 2018

Remember that it is the user that selects what is to be shared. What happens if the user selects a window or a particular display? It would not be appropriate to share audio from other windows or displays which were not selected (by sharing all audio).

@alvestrand
Copy link
Contributor

I think this is a duplicate of #61. Closing as dup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants