Handle video profiles mismatched with colorGamut and transferFunction. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisn
reviewed
Sep 17, 2024
There was a problem hiding this comment.
If we merge #222, "valid video MIME type" will go away. Could this refer to "valid video configuration"? (But see also #222 (comment)).
|
Let's land #222 and then I will update this PR accordingly. |
|
Side note: Add WPT for this and to confirm interop; should be easy to test as it does not rely on actual capabilities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #152.
If the colorGamut and/or transferFunction are not valid for the video contentType, all of the MediaCapabiliitesInfo fields are returned as false.
This PR does not handle the same situation for
encodingInfo().Preview | Diff