Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purpose: badge should be defined as default badge for Notifications API #508

Closed
mounirlamouri opened this issue Oct 25, 2016 · 9 comments
Closed

Comments

@mounirlamouri
Copy link
Member

The purpose property is weakly defined. The only current value, badge is told to be for "where space constraints and/or color requirements differ from those of the application icon" but the characteristics of the icon are not known by the UA and the restrictions depend on the platform.

Shouldn't we define badge as the default icon for the badge property from the Notifications API unless one is specified? Also say that UA can re-use it in situations where an icon following notifications' badge restrictions would make sense? Hopefully, that could help both UA and developers to make the right decision.

Note that badge in general is a very confusing term because AFAIK, Microsoft and Apple use this term for stuff like unread count. Though, I guess the Notifications API picked this name and we are stuck with it.

@delapuente
Copy link

Perhaps it's better to rename badge to simple or flat to align the term with the definition and not to tie our semantics with an specific purpose.

@marcoscaceres
Copy link
Member

Yeah, something like that could work @delapuente ... we should all also check with @daleharvey on the Gecko side, as he is currently implementing the icons stuff and knows the Android APIs well.

@kenchris
Copy link
Collaborator

kenchris commented May 2, 2017

Any update on this?

@marcoscaceres
Copy link
Member

Nothing from our side.

@marcoscaceres
Copy link
Member

@mounirlamouri, is this still a thing?

@mgiuca
Copy link
Collaborator

mgiuca commented May 20, 2020

As far as I know (and I asked around about a year ago), purpose: badge isn't used anywhere, though it was originally intended to be used for notifications.

That gives me a big sense of relief, because I wouldn't want it to be used with its current semantics: "A user agent can present this icon where space constraints and/or color requirements differ from those of the application icon."

There's a PR out (#833) to rename "badge" to "monochrome" and give it a much better defined semantics. At that point, I think it would be reasonable for the Notifications API to refer to that as the default.

@christianliebel
Copy link
Member

#833 has landed in the meantime. However, I’m not sure if it’s feasible to have monochrome as the default, as this purpose is at risk (#905) and, to my knowledge, only the Android platform uses monochrome notification icons.

@NotWoods
Copy link
Member

If other platforms need different icons, perhaps it would be better to use any icon from the manifest as the default, and select the purpose that best matches the platform.

@mgiuca
Copy link
Collaborator

mgiuca commented Jul 8, 2020

I'm not sure if there's any reason to specify a default. Notifications should display the most appropriate icon for the platform, based on the available icons. On Android, that might be monochrome. On another platform, it might just be the standard any icon. There's no need to impose this UI choice in the spec.

@mgiuca mgiuca closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants