Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL when the language is switched #236

Closed
kojiishi opened this issue Sep 12, 2020 · 2 comments · Fixed by #262
Closed

Update URL when the language is switched #236

kojiishi opened this issue Sep 12, 2020 · 2 comments · Fixed by #262
Labels
jlreq-doc:enhancement [JLReq-doc] possible enhancement items on 2nd edition

Comments

@kojiishi
Copy link
Contributor

Often I find contents, then switch language, copy URL, and paste to somewhere, without noticing that the URL may show different language than I'm seeing.

Great if language switching can update the ?lang=xx part of the URL.

@xfq
Copy link
Member

xfq commented Sep 13, 2020

I thought about creating a PR about this before the publication of the current /TR version, but finally did not submit the PR, since I can see both advantages and disadvantages of it.

The advantage is that sharing it with others can reproduce the current state (language) of the document. The disadvantage is that the user (at least for me) may want a "cleaner" URL and doesn't want to get these statuses. Although the parameter can be removed manually (just like the UTM parameters, although the purpose is different), it is a bit troublesome.

That said, it's not a strong opinion and I won't object if this feature is added.

@himorin himorin added the doc:jlreq Used for gap analysis (only) to indicate target document. label Sep 23, 2020
@himorin himorin removed the doc:jlreq Used for gap analysis (only) to indicate target document. label Jan 21, 2021
@kojiishi
Copy link
Contributor Author

@xfq Thanks, I agree it has both pros and cons. I think the advantage is bigger, but it is understandable if others think differently.

I can create a PR, and I'll let reviewers to decide which experience they would like to take.

@himorin himorin added the jlreq-doc:enhancement [JLReq-doc] possible enhancement items on 2nd edition label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jlreq-doc:enhancement [JLReq-doc] possible enhancement items on 2nd edition
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants